Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add recvmsg support for ancillary data #187

Closed
fw-strlen opened this issue May 3, 2021 · 2 comments
Closed

add recvmsg support for ancillary data #187

fw-strlen opened this issue May 3, 2021 · 2 comments
Assignees
@fw-strlen
Labels
enhancement

Comments

@fw-strlen
Copy link

Add support for cmsg(3) to mptcps receive path so we can support SO_TIMESTAMP(NS) option and possibly introduce mptcp-specific notifications in the future.
@fw-strlen fw-strlen self-assigned this May 3, 2021
@matttbe
Copy link
Member

matttbe commented Jun 7, 2021

@fw-strlen if I'm not mistaken, this issue can be closed thanks to your patches:

  • 480085a: sock: expose so_timestamp options for mptcp
  • 1dec92e: sock: expose so_timestamping options for mptcp
  • 1939fa5: mptcp: sockopt: propagate timestamp request to subflows
  • b31cc28: mptcp: setsockopt: handle SOL_SOCKET in one place only
  • e353d97: tcp: export timestamp helpers for mptcp
  • b1555bd: mptcp: receive path cmsg support
  • 7a134f5: selftests: mptcp_connect: add SO_TIMESTAMPNS cmsg support
  • Results: 36f3137..36a7db0

Which are already in net-next:

Is it correct or is there still something missing? :)

Also, does it make sense to support the send part? If yes, it is probably best to create a new issue.

@fw-strlen
Copy link
Author

Agree, we can open new issues if needed, initial cmsg support was added by those commits, thus closing.

@matttbe matttbe mentioned this issue Jun 8, 2021
Open
jenkins-tessares pushed a commit that referenced this issue Nov 17, 2023
@cuiyunhui @palmer-dabbelt
riscv: add userland instruction dump to RISC-V splats
b8a03a6 
Add userland instruction dump and rename dump_kernel_instr()
to dump_instr().

An example:
[    0.822439] Freeing unused kernel image (initmem) memory: 6916K
[    0.823817] Run /init as init process
[    0.839411] init[1]: unhandled signal 4 code 0x1 at 0x000000000005be18 in bb[10000+5fb000]
[    0.840751] CPU: 0 PID: 1 Comm: init Not tainted 5.14.0-rc4-00049-gbd644290aa72-dirty #187
[    0.841373] Hardware name:  , BIOS
[    0.841743] epc : 000000000005be18 ra : 0000000000079e74 sp : 0000003fffcafda0
[    0.842271]  gp : ffffffff816e9dc8 tp : 0000000000000000 t0 : 0000000000000000
[    0.842947]  t1 : 0000003fffc9fdf0 t2 : 0000000000000000 s0 : 0000000000000000
[    0.843434]  s1 : 0000000000000000 a0 : 0000003fffca0190 a1 : 0000003fffcafe18
[    0.843891]  a2 : 0000000000000000 a3 : 0000000000000000 a4 : 0000000000000000
[    0.844357]  a5 : 0000000000000000 a6 : 0000000000000000 a7 : 0000000000000000
[    0.844803]  s2 : 0000000000000000 s3 : 0000000000000000 s4 : 0000000000000000
[    0.845253]  s5 : 0000000000000000 s6 : 0000000000000000 s7 : 0000000000000000
[    0.845722]  s8 : 0000000000000000 s9 : 0000000000000000 s10: 0000000000000000
[    0.846180]  s11: 0000000000d144e0 t3 : 0000000000000000 t4 : 0000000000000000
[    0.846616]  t5 : 0000000000000000 t6 : 0000000000000000
[    0.847204] status: 0000000200000020 badaddr: 00000000f0028053 cause: 0000000000000002
[    0.848219] Code: f06f ff5f 3823 fa11 0113 fb01 2e23 0201 0293 0000 (8053) f002
[    0.851016] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004

Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
Link: https://lore.kernel.org/r/20230912021349.28302-1-cuiyunhui@bytedance.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fw-strlen fw-strlen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matttbe @fw-strlen