Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't expect 'backup' flags in the MP_JOIN SYN in mp_join_client #18

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

dcaratti
Copy link
Collaborator

the additional server address is received via an ADD_ADDR, and there is
currently no way to create 'backup' subflows in this way, after the
upstream kernel removed hardcoded value for that flag. Fix the test
script accordingly.

Closes: multipath-tcp/mptcp_net-next#81
Signed-off-by: Davide Caratti dcaratti@redhat.com

the additional server address is received via an ADD_ADDR, and there is
currently no way to create 'backup' subflows in this way, after the
upstream kernel removed hardcoded value for that flag. Fix the test
script accordingly.

Closes: multipath-tcp/mptcp_net-next#81
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Copy link
Member

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is currently no way to create 'backup' subflows in this way, after the upstream kernel removed hardcoded value for that flag.

Is it not possible to set the flag with netlink?

ip mptcp endpoint add

backup

But we don't do that here.

@matttbe matttbe merged commit 7f9e8e8 into multipath-tcp:mptcp-net-next Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packetdrill detects mismatching 'B' flag in mp_join_client.pkt
2 participants