mptcp: add regression test for disconnect() #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
requested changes
Jan 14, 2021
| @@ -0,0 +1,13 @@ | |||
| // This test case covers the regression fixed by ("mptcp: be careful on MPTCP-level ack.") | |||
| // bad read on on unconnected socket | |||
There was a problem hiding this comment.
I think this comment should be updated :) (from unconnected_read.pkt)
| +0.0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress) | ||
| +0.0 > S 0:0(0) <mss 1460,sackOK,TS val 100 ecr 0,nop,wscale 8,mpcapable v1 flags[flag_h] nokey> | ||
|
|
||
| +0.0 shutdown(3, SHUT_WR) = 0 |
There was a problem hiding this comment.
should we maybe rename this test not to have it too generic? e.g. unconnected_shutdown.pkt (or connect_in_progress_shutdown.pkt or something else :) )
This simply trigger the in-kernel mptcp disconnect code path, so that we can have coverage for: https://marc.info/?l=linux-netdev&m=161053335929207&w=2 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
pabeni
force-pushed
the
mptcp_mptcp-net-next
branch
from
8987957 to
8653fdf
Compare
matttbe
approved these changes
Jan 14, 2021
| @@ -0,0 +1,14 @@ | |||
| // This test case covers the regression fixed by ("mptcp: fix locking in mptcp_disconnect()") | |||
| // shutdown a socket with connect pending, so that mptcp_disconnect() | |||
| // is inoked | |||
matttbe
requested changes
Jan 22, 2021
|
|
||
| // more data, expect a reset and win0 (no socket anymore) | ||
| +1.0 < P. 2001:3001(1000) ack 1 win 450 <nop, nop, dss dack8=1 dsn8=2001 ssn=2001 dll=1000 nocs> | ||
| +0.01 > R 1:1(0) ack 0 win 0 |
|
|
||
| // send rst fastclose with a key that should not match. | ||
| +0 < R. 1001:1001(0) win 450 <mp_fastclose ckey=42 > | ||
|
|
||
| // more data, but expect rst: the subflow is gone. | ||
| +1.0 < P. 1001:2001(1000) ack 1 win 450 <nop, nop, dss dack8=1 dsn8=1001 ssn=1001 dll=1000 nocs> | ||
| +0.02 > R 1:1(0) ack 0 win 0 | ||
| +0.02 > R 1:1(0) ack 0 |
There was a problem hiding this comment.
also this one should be fine, no?
|
|
||
| // send another rst fastclose, this time with matching key | ||
| +0.1 < R. 1001:1001(0) win 450 <mp_fastclose> | ||
|
|
||
| // more data, expect a reset and win0 (no socket anymore) | ||
| +1.0 < P. 2001:3001(1000) ack 1 win 450 <nop, nop, dss dack8=1 dsn8=2001 ssn=1001 dll=1000 nocs> | ||
| +0.01 > R 1:1(0) ack 0 win 0 | ||
| +0.01 > R 1:1(0) ack 0 |
pabeni
force-pushed
the
mptcp_mptcp-net-next
branch
from
068e5f7 to
8653fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply trigger the in-kernel mptcp disconnect
code path, so that we can have coverage for:
https://marc.info/?l=linux-netdev&m=161053335929207&w=2
Signed-off-by: Paolo Abeni pabeni@redhat.com