MP_PRIO smoketest

[dcaratti]

basic functional test that uses inbound MP_PRIO to flip the 'backup' flag
in the MP_JOIN server scenario.

Link: multipath-tcp/mptcp_net-next#51
Signed-off-by: Davide Caratti dcaratti@redhat.com

[matttbe]

Thanks for this PR! It looks good to me!

Just one thing before merging: I don't know if we can close the linked ticket because we don't have a way for the moment to send MP_PRIO. But maybe it is fine, other PMs/extended netlink PM would be able to do that later, maybe no need to add support in iproute2 with a ip mptcp endpoint change ADDRESS [ dev NAME ] [ id ID ] [ FLAG-LIST ]?

Should we discuss about that on the ticket and/or at the next meeting?

[matttbe]

(note that if I merge this, it will close the ticket)

[dcaratti]

(note that if I merge this, it will close the ticket)

.. that's exactly what I was afraid of. I searched another 'tag' in GH documentation, but failed.

I'd keep this ticket open to get the iproute2 bits in (if we agree that it's useful to have them. I believe that it would be useful to see an MP_PRIO flying when we change the endpoint, at least for those that are installed statically; also, I would like to assess correct reception of the MP_PRIO by verifying with iproute2 that 'backup' flipped for real). I can force-push again this patch without the 'Closes:' tag, @matttbe is that ok?

[matttbe]

I can force-push again this patch without the 'Closes:' tag, @matttbe is that ok?

Sounds good to me!
What about using Link: instead of Closes:?

(I think you will still need to modify your first comment on this PR and maybe only this comment counts :) )

[matttbe]

Thank you for the new commit message :)