fix support for outbound echoed ADD_ADDR #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
requested changes
Feb 24, 2021
gtests/net/mptcp/fastclose/receive_fastclose_with_ack_multi_v4.pkt
Outdated
Show resolved
Hide resolved
dcaratti
force-pushed
the
gh54
branch
2 times, most recently
from
6515047
to
e4bd8d7
Compare
matttbe
requested changes
Mar 2, 2021
gtests/net/mptcp/fastclose/receive_fastclose_with_rst_multi_v4.pkt
Outdated
Show resolved
Hide resolved
- fix segmentation fault in case the endpoint is not found - fix wrong endpoint "guess" when port is not specified Link: multipath-tcp/mptcp_net-next#54 Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe
requested changes
Mar 3, 2021
matttbe
reviewed
Mar 3, 2021
|
|
||
| // close connection | ||
| +0.0 < addr[caddr0] > addr[saddr0] F. 3:3(0) ack 1 win 256 <nop, nop, TS val 4074418292 ecr 4074418293, dss dack4=1 dsn8=3 ssn=0 dll=1 nocs fin, nop, nop> | ||
| +0.0 < > addr[saddr1] F. 1:1(0) ack 1 win 256 <nop, nop, TS val 448955294 ecr 448955294> | ||
| +0.0 < > addr[saddr1] F. 1:1(0) ack 1 win 256 |
There was a problem hiding this comment.
not sure we need to modify this line but maybe not hurting
while at it, change parser to use a keyword to specify the echo bit set in ADD_ADDR messages. Link: multipath-tcp/mptcp_net-next#54 Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.