mptcp: add explicit test for MPC with OoO pkts (server side) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly cover the critical scenario triggering: multipath-tcp/mptcp_net-next#192 and should fail till the kernel patch: "mptcp: always parse mptcp options for MPC reqsk" is merged Signed-off-by: Paolo Abeni <pabeni@redhat.com>
mjmartineau
reviewed
May 18, 2021
There was a problem hiding this comment.
I get a parsing error when I try to run this case:
FAIL [/home/mjmartin/work/packetdrill/gtests/net/mptcp/mp_capable/v1_mp_capable_bind_no_cs_ooo.pkt (ipv4)]
stdout:
stderr:
v1_mp_capable_bind_no_cs_ooo.pkt:13: parse error at 'mpcdatalen': syntax error
I tried a clean build of packetdrill and no luck. Could be a problem with my setup, but the existing tests run ok.
Well, please disregard. I think I had bad command line parameters, it's working fine now with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly cover the critical scenario triggering:
multipath-tcp/mptcp_net-next#192
and should fail till the kernel patch:
"mptcp: always parse mptcp options for MPC reqsk"
is merged
Signed-off-by: Paolo Abeni pabeni@redhat.com