Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In my current project we use rollbar-sourcemap-webpack-plugin, this plugin generate and upload .js.map files on build process. All .js.map files is recommended to no be public:
I believe this is a common pattern and other projects should have the same problem
Workaround
For now before of
npm run deploy
we runningrm -R dist/js/*.map
but I believe this should be the responsibility of the deploy tool.Solution
Add another optional config (
ignoreMatch
) to permit ignore some files based on Globbing patterns.I think this config should be as default something like
!**/*.map
, but to not generate break change, suggest the default as an empty string for now.