Fix ACL request detection when using refresh (#1824) #4409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
requested changes
Sep 4, 2025
MohabCodeX
force-pushed
the
fix/refresh-aclrequest
branch
from
727d8d1 to
e55141a
Compare
FileEX
requested changes
Sep 5, 2025
FileEX
approved these changes
Sep 6, 2025
FileEX
pushed a commit
that referenced
this pull request
Sep 16, 2025
refresh isn't meant to restart, just refreshall does that. (fix after #4409)
PerikiyoXD
added a commit
to PerikiyoXD/mtasa-blue
that referenced
this pull request
Sep 26, 2025
…1824) (multitheftauto#4409)" This reverts commit d0e210a.
PerikiyoXD
added a commit
to PerikiyoXD/mtasa-blue
that referenced
this pull request
Sep 26, 2025
…1824) (multitheftauto#4409)" This reverts commit d0e210a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurred because the system skipped creating the necessary ACL structures when permissions already existed elsewhere. Additionally, it now ensures consistent cleanup of temporary ACL entries and prevents any permission leakage.
Fixes #1824