Fix getVehicleCompatibleUpgrades returns different value on client/server
#4569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3248, #2476
Looks like several typos and logical errors caused these issues.
Now the client and server are in sync, I’ve tested it with multiple vehicles as well.
Important
Spoilers are now allowed on all vehicles on the client side as well. Previously, this wasn’t the case, so it could happen that if you replaced a vehicle and the server applied a spoiler, it would disappear (this was probably the cause). This check existed on the server side but not on the client side, which caused a discrepancy between the two. If you add a spoiler to vehicle which has no ug_spoiler dummy, spoiler will spawn to centre of vehicle. Now, all upgrade IDs should be fully synchronized.