Fixed desync of position on server side when player is dead #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, instead of making pull requests on your fork, you can follow the instructions here. |
|
Microoptimization: you could append the body of the if statement that starts on line 411 to the end of the if statement you changed, because they now check the same condition. That way you surely avoid checking the same condition twice, and reduce 2 lines of code. |
qaisjp
pushed a commit
that referenced
this pull request
May 28, 2019
qaisjp
added a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says. Not tested with more than local player, however it fixes #928 and probably(not tested) #908. Should fix most of desyncs when player is dead, because right now client doesn't send any sync when player died.