-
-
Notifications
You must be signed in to change notification settings - Fork 170
[editor_gui] Improved object preview #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes: - fixed object not appearing when selecting certain model ids - object rotation in viewport is centered - removed zoom out limit - added doublesided property to previewed element
Nice but some objects aren't supposed to be double sided? |
you're right, I thought about the outcomes of it, but I considered that there are more objects that need easier viewing (mostly landbits and vegetation) and there are only a few models that might look out of place when doublesided is applied to them we'll have to see if it's required to either keep the property or remove it |
What about a checkbox to view with / without double sided? |
Should be a lot better now @Fernando-A-Rocha @ArranTuna ![]() |
That's cool. Any other object properties you could put as check boxes next to that double-sided one? |
@Fernando-A-Rocha besides alpha, I don't think there's anything else to add. Perhaps we may include extra features (possibly regarding camera) in a separate PR until this one is reviewed |
Would be nice to be able to change the sky gradient inside the object browser that way weather and time could still stay the same but you dont have that bright glare while browsing right in your face |
Everything looks right. Will merge unless anyone has any complaints. |
Great, more features can come in subsequent PRs |
fixes: