-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes and tokens fetch from external api #1306
Merged
tanghel
merged 17 commits into
development
from
SERVICES-2546-nodes-and-tokens-fetch-from-external-api
Sep 10, 2024
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fc202b1
updated devnet config
tanghel 28a68b1
Signed commit test
GuticaStefan 2e4f1f8
Signed commit restore changes
GuticaStefan 2115f2d
Signed commit test
GuticaStefan 1bac72e
Signed message restore changes
GuticaStefan f219c43
Added tokens fetch from external API
GuticaStefan 5208be5
Added nodes fetch from external API
GuticaStefan dd83121
Add ApiService as provider in tests
GuticaStefan da4c491
Add nodes/tokens fetch features in config files
GuticaStefan c679989
Add unit tests for external api
MogageNicolae a5cb1ac
Divide requests for nodes and tokens in smaller requests containing m…
GuticaStefan 9eee572
Wrong function call when fetching nodes fixed
GuticaStefan 484a205
refactoring
gabrielmatei 9a3d752
simplified node / token fetching
tanghel f3cbf54
Merge branch 'development' into SERVICES-2546-nodes-and-tokens-fetch-…
tanghel cc1d2ea
Fixed tests bug
MogageNicolae 8488f74
Merge branch 'development' into SERVICES-2546-nodes-and-tokens-fetch-…
tanghel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -869,4 +869,30 @@ export class ApiConfigService { | |
|
||
return deepHistoryUrl; | ||
} | ||
|
||
isTokensFetchFeatureEnabled(): boolean { | ||
return this.configService.get<boolean>('features.tokensFetch.enabled') ?? false; | ||
} | ||
|
||
getTokensFetchServiceUrl(): string { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add some unit test for the new api config service methods in api config service spec file |
||
const serviceUrl = this.configService.get<string>('features.tokensFetch.serviceUrl'); | ||
if (!serviceUrl) { | ||
throw new Error('No tokens fetch service url present'); | ||
} | ||
|
||
return serviceUrl; | ||
} | ||
|
||
isNodesFetchFeatureEnabled(): boolean { | ||
return this.configService.get<boolean>('features.nodesFetch.enabled') ?? false; | ||
} | ||
|
||
getNodesFetchServiceUrl(): string { | ||
const serviceUrl = this.configService.get<string>('features.nodesFetch.serviceUrl'); | ||
if (!serviceUrl) { | ||
throw new Error('No nodes fetch service url present'); | ||
} | ||
|
||
return serviceUrl; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the new features above dataApi
dataApi:
enabled: false
serviceUrl: 'https://data-api.multiversx.com'