Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'addresses' query parameter to filter accounts by a list of addresses #1374

Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Nov 7, 2024

Proposed Changes

  • Introduces a new query parameter to filter accounts by a list of addresses and includes validation to ensure the addresses array does not exceed 25 elements.

How to test

  • <api>/accounts?addresses=erd1an4xpn58j7ymd58m2jznr32t0vmas75egrdfa8mta6fzvqn9tkxq4jvghn,erd1kyle4p6chlvj0u6fyds7wj47jqwq6kh9h083kw8j76254l8u49dqepfz86
  • <api>/accounts?addresses[... >25 ] -> should throw 400 Bad Request

Copy link

github-actions bot commented Nov 7, 2024

k6 load testing comparison.
Base Commit Hash: 6a03f1f
Target Commit Hash: e74172c

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Tokens51.00179.7357.1158.8449.47592.3054.7456.59-2.99% ✅+229.56% 🔴-4.15% ✅-3.83% ✅
Blocks58.851486.3557.3559.9757.731691.4355.2359.39-1.91% ✅+13.80% 🔴-3.71% ✅-0.97% ✅
Nodes51.45524.3357.1558.8549.18529.2254.7556.64-4.40% ✅+0.93% 🔴-4.21% ✅-3.75% ✅
Pool51.35384.5357.1559.0348.96469.5354.7356.70-4.65% ✅+22.11% 🔴-4.24% ✅-3.93% ✅
Mex50.95143.3157.0758.7448.86265.2954.7556.66-4.11% ✅+85.11% 🔴-4.06% ✅-3.53% ✅
Transactions76.402714.3758.1663.1072.792885.8055.7261.80-4.72% ✅+6.32% 🔴-4.20% ✅-2.06% ✅
Accounts52.24950.4857.2258.7350.521349.0354.6456.29-3.29% ✅+41.93% 🔴-4.50% ✅-4.14% ✅
Test Run Duration60002.7360004.31

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu self-requested a review November 7, 2024 10:26
@cfaur09 cfaur09 self-assigned this Nov 8, 2024
@dragos-rebegea dragos-rebegea merged commit 5079d6b into development Dec 12, 2024
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-53-add-support-fetching-a-list-of-addresses branch December 12, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants