Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if nft.type exist and add NftSubType filter #1394

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Nov 22, 2024

Reasoning

  • some tokens does not contain in ES type field

Proposed Changes

  • check if type field is defined
  • add DynamicSemiFungibleESDT and DynamicMetaESDT

Copy link

k6 load testing comparison.
Base Commit Hash: 9638379
Target Commit Hash: 1fc11f7

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Accounts46.34112.3750.8252.0946.911107.2550.2151.90+1.22% 🔴+885.38% 🔴-1.20% ✅-0.37% ✅
Mex46.88580.6350.9752.1545.79516.7850.1051.83-2.33% ✅-11.00% ✅-1.71% ✅-0.62% ✅
Transactions60.471393.8551.1953.4462.412018.4751.0554.21+3.22% 🔴+44.81% 🔴-0.29% ✅+1.45% 🔴
Nodes46.98606.2250.8552.1645.95542.0550.0951.71-2.20% ✅-10.58% ✅-1.49% ✅-0.86% ✅
Pool47.10776.1750.9052.1446.07436.6450.1251.74-2.19% ✅-43.74% ✅-1.54% ✅-0.76% ✅
Blocks54.711441.0051.1352.6453.131546.6650.7253.22-2.89% ✅+7.33% 🔴-0.80% ✅+1.10% 🔴
Tokens47.06820.1450.8452.1746.03505.3850.1051.75-2.18% ✅-38.38% ✅-1.46% ✅-0.81% ✅
Test Run Duration60003.9060004.76

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 self-assigned this Dec 10, 2024
@dragos-rebegea dragos-rebegea merged commit c051521 into development Dec 12, 2024
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-93-check-for-type-in-get-nft-single branch December 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants