Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-334: add option to include relayed sc results #1414

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • Transactions for a sender/receiver that were relayed did not appear in the /transactions endpoint results.

Proposed Changes

  • Added an optional flag withRelayedScresults to the /transactions, /transactions/count, /transactions/c so those transactions will also be included
  • In order to compute the query, we need to identify operations of type 'unsigned' where 'relayerAddr' field is not missing and 'originalTxHash' is the same as 'prevTxHash'

How to test

  • http://localhost:3001/transactions/count?sender=erd1efe954adel2jchnl98xt2gnkrtz0gwpap5ap2mzwvuez0d5344qs2llhcv
  • http://localhost:3001/transactions/count?sender=erd1efe954adel2jchnl98xt2gnkrtz0gwpap5ap2mzwvuez0d5344qs2llhcv&withRelayedScresults=true
    the difference between them should be 3.

@bogdan-rosianu bogdan-rosianu added the feature New feature or request label Dec 9, 2024
@bogdan-rosianu bogdan-rosianu self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

k6 load testing comparison.
Base Commit Hash: c719f9c
Target Commit Hash: eaad7c8

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Transactions62.232029.8652.5755.0862.392620.1951.1853.50+0.26% 🔴+29.08% 🔴-2.64% ✅-2.86% ✅
Mex48.05417.1252.0253.6446.53445.9850.3751.77-3.17% ✅+6.92% 🔴-3.18% ✅-3.47% ✅
Accounts48.68720.0752.0653.5347.17979.0550.3351.72-3.10% ✅+35.97% 🔴-3.33% ✅-3.39% ✅
Blocks53.711210.8152.5655.7353.701545.3550.9652.94-0.03% ✅+27.63% 🔴-3.04% ✅-5.02% ✅
Tokens48.06343.1552.0153.5846.25240.0050.3651.87-3.78% ✅-30.06% ✅-3.17% ✅-3.20% ✅
Nodes47.93447.1051.9853.5747.691527.2750.3651.89-0.50% ✅+241.59% 🔴-3.12% ✅-3.14% ✅
Pool48.05278.2151.9853.6346.20109.3150.4151.99-3.85% ✅-60.71% ✅-3.02% ✅-3.05% ✅
Test Run Duration60007.9960005.61

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

gabrielmatei
gabrielmatei previously approved these changes Dec 9, 2024
cfaur09
cfaur09 previously approved these changes Dec 9, 2024
…nder

# Conflicts:
#	src/endpoints/transactions/entities/transaction.filter.ts
@bogdan-rosianu bogdan-rosianu dismissed stale reviews from cfaur09 and gabrielmatei via eaad7c8 December 9, 2024 15:14
@bogdan-rosianu bogdan-rosianu merged commit ddd5805 into development Dec 10, 2024
5 checks passed
@bogdan-rosianu bogdan-rosianu deleted the API-334-relayed-txs-for-sender branch December 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants