Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check to ensure providersDelegationData is an array #1420

Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Dec 11, 2024

Proposed Changes

  • check if response from getDelegationProviders is array

How to test

  • `/accounts/erd1qqqqqqqqqqqqqpgqa0fsfshnff4n76jhcye6k7uvd7qacsq42jpsp6shh2 -> should not return 500 internal server error

Copy link

github-actions bot commented Dec 11, 2024

k6 load testing comparison.
Base Commit Hash: 5c112f4
Target Commit Hash: 58e2c08

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Transactions68.665246.3954.7956.7168.064513.8155.3256.99-0.87% ✅-13.96% ✅+0.97% 🔴+0.50% 🔴
Nodes50.16547.1354.0855.8551.42906.8154.9055.90+2.51% 🔴+65.74% 🔴+1.53% 🔴+0.10% 🔴
Mex50.05720.6154.1255.8351.41961.6754.9356.06+2.72% 🔴+33.45% 🔴+1.49% 🔴+0.42% 🔴
Pool50.56927.6954.1055.6850.88283.6954.8956.04+0.63% 🔴-69.42% ✅+1.45% 🔴+0.64% 🔴
Accounts49.72170.2154.0655.8750.55122.1454.8855.99+1.66% 🔴-28.24% ✅+1.52% 🔴+0.21% 🔴
Tokens50.49832.1554.1455.7851.25980.0854.9256.01+1.50% 🔴+17.78% 🔴+1.44% 🔴+0.41% 🔴
Blocks57.081481.8154.6156.8257.071146.1055.2657.11-0.01% ✅-22.66% ✅+1.20% 🔴+0.51% 🔴
Test Run Duration60004.3760004.30

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 merged commit aae3354 into development Dec 11, 2024
4 checks passed
@cfaur09 cfaur09 deleted the API-342-ensure-that-providers-delegation-data-is-array branch December 11, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants