Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update applications endpoint #1443

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Jan 29, 2025

Proposed Changes

  • implemented Promise.All when fetching balance from gatewayService for every application
  • implemented withTxCount filter to define txCount for every application
  • updated specs for applications

How to test

  • <api>applications?withTxCount=true -> should return txCount field
  • <api>applications -> response should contain balance field

@cfaur09 cfaur09 self-assigned this Jan 29, 2025
@cfaur09 cfaur09 added the feature New feature or request label Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

k6 load testing comparison.
Base Commit Hash: 3868a97
Target Commit Hash: 0c370cf

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes51.451404.4754.5256.1447.62270.0752.0953.67-7.44% ✅-80.77% ✅-4.45% ✅-4.40% ✅
Mex49.70127.3154.4656.0847.83363.4452.1453.87-3.76% ✅+185.48% 🔴-4.26% ✅-3.93% ✅
Blocks57.451268.2555.0958.4755.001414.2152.7254.63-4.27% ✅+11.51% 🔴-4.30% ✅-6.57% ✅
Accounts51.341242.0554.4756.2849.031234.9752.2153.72-4.49% ✅-0.57% ✅-4.15% ✅-4.55% ✅
Transactions69.685795.6855.3158.4766.525809.3052.9855.55-4.53% ✅+0.24% 🔴-4.22% ✅-5.00% ✅
Tokens50.45667.7354.4956.2847.67253.6752.1053.74-5.51% ✅-62.01% ✅-4.39% ✅-4.51% ✅
Pool50.53628.3854.5456.1748.55880.2452.2053.86-3.93% ✅+40.08% 🔴-4.29% ✅-4.12% ✅
Test Run Duration60008.5760001.84

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.


promises.push((async () => {
try {
const { account: { balance } } = await this.gatewayService.getAddressDetails(application.contract);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: we could have used POST /address/bulk for fetching the state of more addresses

bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants