-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update applications endpoint #1443
base: development
Are you sure you want to change the base?
Conversation
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|
||
promises.push((async () => { | ||
try { | ||
const { account: { balance } } = await this.gatewayService.getAddressDetails(application.contract); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: we could have used POST /address/bulk
for fetching the state of more addresses
Proposed Changes
balance
fromgatewayService
for every applicationwithTxCount
filter to definetxCount
for every applicationHow to test
<api>applications?withTxCount=true -> should return txCount field
<api>applications -> response should contain balance field