Bugs/en 2588 fix direct sender #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enger now sends async requests and always return nil error.
p2p/libp2p/directSender.go
Outdated
| go func() { | ||
| err := ds.Send(topic, buff, peer) | ||
| if err != nil { | ||
| log.Debug(err.Error()) |
There was a problem hiding this comment.
I would change this to log.Info to see if we still have some errors here
There was a problem hiding this comment.
changed to log.Info
SebastianMarian
approved these changes
Jun 24, 2019
raduchis
approved these changes
Jun 24, 2019
| return netMes.ds.Send(topic, buff, peerID) | ||
| netMes.ds.SendAsync(topic, buff, peerID) | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Do we still need the error?
There was a problem hiding this comment.
Not quite. It just satisfy the interface.
ccorcoveanu
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.