esdt improvements integration #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeniaminDrasovean
changed the title
sasurobert
previously approved these changes
Jan 9, 2024
Base automatically changed from
esdt-tokenType-storage-opt
to
feat/esdt-improvements
January 10, 2024 10:21
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/esdt-improvements #5806 +/- ##
==========================================================
+ Coverage 80.36% 80.40% +0.04%
==========================================================
Files 710 710
Lines 94310 94310
==========================================================
+ Hits 75789 75830 +41
+ Misses 13227 13186 -41
Partials 5294 5294 ☔ View full report in Codecov by Sentry. |
| @@ -697,9 +697,9 @@ func (handler *enableEpochsHandler) createAllFlagsMap() { | |||
| }, | |||
| common.DynamicESDTFlag: { | |||
| isActiveInEpoch: func(epoch uint32) bool { | |||
| return epoch >= handler.enableEpochsConfig.NFTStopCreateEnableEpoch | |||
| return epoch >= handler.enableEpochsConfig.DynamicESDTEnableEpoch | |||
| } | ||
|
|
||
| // SetTokenType does nothing as this is a disabled component | ||
| func (d *disabledGlobalSettingsHandler) SetTokenType(_ []byte, _ uint32) error { |
There was a problem hiding this comment.
this is no longer a GlobalSettingHandler. Why do we have this function here?
There was a problem hiding this comment.
The token type is saved in ESDTGlobalMetadata . GlobalSettingHandler manages ESDTGlobalMetadata
…t-improvements-integration # Conflicts: # common/constants.go # go.mod # go.sum
iulianpascalau
approved these changes
Jan 31, 2024
|
|
||
| func TestESDTMetaDataRecreate(t *testing.T) { | ||
| tokenTypes := getDynamicTokenTypes() | ||
| for _, tokenType := range tokenTypes { |
sasurobert
approved these changes
Feb 5, 2024
BeniaminDrasovean
merged commit 0753e2c
into
feat/esdt-improvements
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?