Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/v1.6.next1 #5945

Merged
merged 93 commits into from
Mar 14, 2024
Merged

Rc/v1.6.next1 #5945

merged 93 commits into from
Mar 14, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 93.58491% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 80.17%. Comparing base (d5bb384) to head (935273d).
Report is 7 commits behind head on master.

Files Patch % Lines
factory/api/apiResolverFactory.go 88.75% 7 Missing and 2 partials ⚠️
state/accountsDBApi.go 64.28% 3 Missing and 2 partials ⚠️
...esolverscontainer/baseResolversContainerFactory.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5945      +/-   ##
==========================================
- Coverage   80.18%   80.17%   -0.02%     
==========================================
  Files         709      709              
  Lines       94135    94166      +31     
==========================================
+ Hits        75486    75501      +15     
- Misses      13301    13316      +15     
- Partials     5348     5349       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau marked this pull request as ready for review March 13, 2024 18:37
sstanculeanu
sstanculeanu previously approved these changes Mar 13, 2024
sasurobert
sasurobert previously approved these changes Mar 13, 2024
raduchis
raduchis previously approved these changes Mar 13, 2024
andreibancioiu
andreibancioiu previously approved these changes Mar 13, 2024
@iulianpascalau iulianpascalau merged commit 5e1569b into master Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants