Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc170 into rc17next1 2024.03.21 #6058

Merged
merged 1,258 commits into from
Mar 22, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

andreibancioiu and others added 30 commits February 17, 2024 22:02
proper flag for GovernanceFlagInSpecificEpochOnly
…y-service

Fixed recreate trie in sc query service
iulianpascalau and others added 21 commits March 14, 2024 16:57
…simulator

Applied custom arch config tweaks on the chain simulator
…cenario

Added stake-unstake-unbond scenario + EEI fix
…tion

remove all nodes from queue on the activation of staking v4.
…factor

Uniformized the calling methods for integration tests
….03.20

Merge master into rc170 2024.03.20
@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Mar 21, 2024
@sstanculeanu sstanculeanu self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 84.81435% with 364 lines in your changes are missing coverage. Please review.

Project coverage is 78.80%. Comparing base (6d6332c) to head (6d93fee).
Report is 1 commits behind head on rc/v1.7.next1.

Files Patch % Lines
epochStart/metachain/legacySystemSCs.go 71.99% 118 Missing and 108 partials ⚠️
factory/api/apiResolverFactory.go 81.25% 19 Missing and 2 partials ⚠️
epochStart/metachain/auctionListDisplayer.go 87.40% 9 Missing and 7 partials ⚠️
factory/processing/blockProcessorCreator.go 83.56% 6 Missing and 6 partials ⚠️
epochStart/metachain/systemSCs.go 85.13% 8 Missing and 3 partials ⚠️
epochStart/bootstrap/baseStorageHandler.go 37.50% 5 Missing and 5 partials ⚠️
epochStart/metachain/auctionListSelector.go 97.13% 5 Missing and 2 partials ⚠️
epochStart/metachain/common.go 0.00% 7 Missing ⚠️
epochStart/metachain/tableDisplayer.go 36.36% 7 Missing ⚠️
genesis/process/genesisBlockCreator.go 66.66% 4 Missing and 3 partials ⚠️
... and 13 more
Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.7.next1    #6058      +/-   ##
=================================================
- Coverage          79.93%   78.80%   -1.13%     
=================================================
  Files                731      752      +21     
  Lines              96250    98013    +1763     
=================================================
+ Hits               76934    77238     +304     
- Misses             13927    15553    +1626     
+ Partials            5389     5222     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> merge_rc170_into_rc17next1-6d93fee1ff

--- Specific errors ---

block hash does not match 1711
wrong nonce in block 665
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 329
Nr. of new ERRORS: 0
Nr. of new WARNS: 5
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@sstanculeanu sstanculeanu merged commit 347ff4e into rc/v1.7.next1 Mar 22, 2024
9 of 10 checks passed
@sstanculeanu sstanculeanu deleted the merge_rc170_into_rc17next1_2024.03.21 branch March 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants