ESDT improvements chain simulator tests and fixes #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // 8. check that the metaData for the NFT was removed from the system account and moved to the user account | ||
| // 9. check that the metaData for the rest of the tokens is still present on the system account and not on the userAccount | ||
| // 10. do the test for both intra and cross shard txs | ||
| func TestChainSimulator_CheckTokensMetadata_TransferTokens(t *testing.T) { |
There was a problem hiding this comment.
Repeat these tests for MultiESDTNFTTransfer also
There was a problem hiding this comment.
added also tests with MultiESDTNFTTransfer
BeniaminDrasovean
approved these changes
Jun 7, 2024
ssd04
changed the title
sasurobert
approved these changes
Jun 11, 2024
gabi-vuls
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Normal allin test: 1.7.12-2a6916fbce -> esdt-improvements-integrat-a3556df3a8
--- Specific errors ---
block hash does not match 1833
wrong nonce in block 772
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 529
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?