Remove consensus group size chain simulator #6248
Conversation
| } | ||
|
|
||
| type ArgsBaseChainSimulator struct { | ||
| ArgsChainSimulator | ||
| ConsensusGroupSize uint32 |
There was a problem hiding this comment.
Useless, the chain simulator does not work with something else other than 1 here.
There was a problem hiding this comment.
This helps for Sovereign Chain Simulator
| AlterConfigsFunction func(cfg *config.Configs) | ||
| } | ||
|
|
||
| type ArgsBaseChainSimulator struct { |
There was a problem hiding this comment.
missing comment, useless struct, anyway
There was a problem hiding this comment.
Normal allin test: 1.7.12-2a6916fbce -> remove-consensus-group-siz-1a92d80213
--- Specific errors ---
block hash does not match 1784
wrong nonce in block 836
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 368
Nr. of new ERRORS: 0
Nr. of new WARNS: 4
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
The chain simulator works only with size 1 of the meta/shard consensus group.
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?