Optimization: encode hash to hex only on log TRACE level set #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Jul 29, 2024
cristure
changed the title
trie/patriciaMerkleTrie_test.go
Outdated
| @@ -1708,3 +1709,32 @@ func BenchmarkPatriciaMerkleTrie_RootHashAfterChanging30000NodesInBatchesOf200(b | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestTrieUpdateTimer(t *testing.T) { | |||
There was a problem hiding this comment.
This unit test:
- is skipped
- has no assertions
- does a print line
Instead, let's get the output of this test, or of the existing benchmarks - before & after the fix, and put the output (textual) in the PR description. Then, we can drop this test.
There was a problem hiding this comment.
yes, we can remove the test after we have the results.
There was a problem hiding this comment.
Fixed (transformed into a benchmark test).
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
andreibancioiu
changed the title
AdoAdoAdo
approved these changes
Sep 6, 2024
miiu96
approved these changes
Sep 6, 2024
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
andreibancioiu
approved these changes
Sep 6, 2024
andreibancioiu
changed the base branch from
rc/v1.7.next1
to
MX-16107-no-more-notify
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Reasonable optimization on trie updates. Improved update times by roughly 30%.
Before fix:
After fix:
Proposed changes
Testing procedure
go test -run=^$ -bench ^BenchmarkPatriciaMerkleTrie_Update$ -benchtime=10xPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?