Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic roles singular #6357

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Dynamic roles singular #6357

merged 5 commits into from
Aug 1, 2024

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Jul 31, 2024

Reasoning behind the pull request

  • Fix missing role in singular roles check
  • Added integration test

Testing procedure

  • Standard system test
  • register dynamic token --> try to set ESDTRoleNFTUpdate role multiple times

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Jul 31, 2024
sstanculeanu
sstanculeanu previously approved these changes Jul 31, 2024
sasurobert
sasurobert previously approved these changes Jul 31, 2024
@ssd04 ssd04 dismissed stale reviews from sasurobert and sstanculeanu via f9aadac July 31, 2024 11:18
@elvisboghiu
Copy link
Contributor

elvisboghiu commented Aug 1, 2024

System test report:
--- Specific errors ---

block hash does not match 1502
wrong nonce in block 720
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 462
Nr. of new ERRORS: 0
Nr. of new WARNS: 28
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

do-ams-validator-19 :
Warn: trie recreate error: error = getNodeFromDB error: key not found for key root = 1

do-ams-validator-25 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-23 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 6

do-ams-validator-34 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-29 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 5

do-ams-validator-35 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2

do-ams-validator-4 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-16 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-26 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-15 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-20 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-13 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2

do-ams-validator-33 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

do-ams-validator-27 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1
Warn: basePreProcess.saveTransactionToStorage txHash = dataUnit = TransactionUnit error = missing transaction 2
Warn: basePreProcess.createMarshalledData: tx not found hash = 1

/------/

@elvisboghiu elvisboghiu self-requested a review August 1, 2024 09:23
@ssd04 ssd04 merged commit 867b9c8 into rc/v1.7.next1 Aug 1, 2024
8 checks passed
@ssd04 ssd04 deleted the dynamic-roles-singular branch August 1, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants