Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mempool: bit of refactoring, chain simulator tests #6654

Merged
merged 16 commits into from
Jan 16, 2025
Merged

Mempool: bit of refactoring, chain simulator tests #6654

merged 16 commits into from
Jan 16, 2025
+555 −29

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Dec 5, 2024 •
edited
Loading

Reasoning behind the pull request

  • We have to cover mempool's behavior - in conjunction with relayed V3 transactions - in chain simulator tests, as well.

Proposed changes

  • Additional integration tests.
  • A trivial refactoring of production code (renaming).

Testing procedure

  • No testing needed.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@andreibancioiu andreibancioiu changed the base branch from master to rc/spica-patch-mempool December 5, 2024 11:05
@andreibancioiu andreibancioiu self-assigned this Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 392d91892ce1dddd907c9bef6744fcfc18414d69
  • Current Branch: MX-16207-mempool-chain-simulator
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-111910
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@andreibancioiu andreibancioiu changed the base branch from rc/spica-patch-mempool to feat/relayedv3 December 19, 2024 09:17
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@andreibancioiu andreibancioiu marked this pull request as ready for review January 10, 2025 12:30
@andreibancioiu andreibancioiu marked this pull request as draft January 10, 2025 12:30
@andreibancioiu andreibancioiu marked this pull request as ready for review January 16, 2025 09:27
sstanculeanu
sstanculeanu previously approved these changes Jan 16, 2025
View reviewed changes
integrationTests/chainSimulator/mempool/testutils_test.go
return participants
}

type noncesTracker struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should export these in further PRs and reuse them in other tests 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added MX-16448 (a bit of effort to make them nicer & generic).

AdoAdoAdo
AdoAdoAdo previously approved these changes Jan 16, 2025
View reviewed changes
@andreibancioiu andreibancioiu merged commit 9f12905 into feat/relayedv3 Jan 16, 2025
5 checks passed
@andreibancioiu andreibancioiu deleted the MX-16207-mempool-chain-simulator branch January 16, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@sstanculeanu sstanculeanu sstanculeanu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @sstanculeanu @AdoAdoAdo