- fixes after review

multiversx · Jun 9, 2023 · 94ba35e · 94ba35e
1 parent 1405694
commit 94ba35e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/integrationTests/peerConnections/peerConnections_test.go b/integrationTests/peerConnections/peerConnections_test.go
@@ -111,7 +111,6 @@ func TestPeerConnectionsOnAllSupportedProtocolsShouldExchangeData(t *testing.T)
 	require.Nil(t, err)
 	addressToConnect = getAddressMatching(seeder.Addresses(), "/quic-v1/", "")
 	err = webTransportPeer.ConnectToPeer(addressToConnect)
-	fmt.Println(webTransportPeer.ID().Pretty())
 	require.Nil(t, err)
 
 	// create a common topic on all messengers
@@ -150,11 +149,9 @@ func TestPeerConnectionsOnAllSupportedProtocolsShouldExchangeData(t *testing.T)
 
 	mutMessages.Unlock()
 
-	defer func() {
-		for _, mes := range messengers {
-			_ = mes.Close()
-		}
-	}()
+	for _, mes := range messengers {
+		_ = mes.Close()
+	}
 }
 
 func getAddressMatching(addresses []string, including string, excluding string) string {

diff --git a/libp2p/netMessenger.go b/libp2p/netMessenger.go
@@ -262,13 +262,13 @@ func parseTransportOptions(configs config.TransportConfig, port int) ([]libp2p.O
 		}
 	}
 
-	quickAddress := configs.QUICAddress
-	if len(quickAddress) > 0 {
-		if !strictCheckStringForIntMarkup(quickAddress) {
+	quicAddress := configs.QUICAddress
+	if len(quicAddress) > 0 {
+		if !strictCheckStringForIntMarkup(quicAddress) {
 			return nil, nil, p2p.ErrInvalidQUICAddress
 		}
 
-		addresses = append(addresses, fmt.Sprintf(quickAddress, port))
+		addresses = append(addresses, fmt.Sprintf(quicAddress, port))
 		options = append(options, libp2p.Transport(quic.NewTransport))
 	}
 

diff --git a/libp2p/netMessenger_test.go b/libp2p/netMessenger_test.go
@@ -2224,7 +2224,7 @@ func TestParseTransportOptions(t *testing.T) {
 			assert.Equal(t, "/ip4/127.0.0.1/tcp/100", addresses[0])
 			assert.Nil(t, err)
 		})
-		t.Run("without port reuse, should work", func(t *testing.T) {
+		t.Run("with port reuse, should work", func(t *testing.T) {
 			options, addresses, err := libp2p.ParseTransportOptions(
 				config.TransportConfig{
 					TCP: config.TCPProtocolConfig{