Merge pull request #22 from multiversx/hw-06

Update examples wrt. new signing providers
multiversx · May 8, 2023 · 8a1f4f0 · 8a1f4f0
2 parents 43535e4 + f2b2d9c
commit 8a1f4f0
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 29 deletions.
diff --git a/signing-providers/package-lock.json b/signing-providers/package-lock.json
diff --git a/signing-providers/package.json b/signing-providers/package.json
@@ -11,8 +11,8 @@
     "@multiversx/sdk-wallet": "4.0.0",
     "@multiversx/sdk-core": "12.1.0",
     "@multiversx/sdk-extension-provider": "2.0.7",
-    "@multiversx/sdk-hw-provider": "5.0.0",
-    "@multiversx/sdk-web-wallet-provider": "2.3.0",
+    "@multiversx/sdk-hw-provider": "6.0.0",
+    "@multiversx/sdk-web-wallet-provider": "3.0.0",
     "@multiversx/sdk-wallet-connect-provider": "3.2.1",
     "qrcode": "1.5.1",
     "qs": "6.10.3"

diff --git a/signing-providers/src/hw.js b/signing-providers/src/hw.js
@@ -67,9 +67,9 @@ export class HW {
             chainID: "T"
         });
 
-        await this.provider.signTransaction(transaction);
+        const signedTransaction = await this.provider.signTransaction(transaction);
 
-        this.displayOutcome("Transaction signed.", transaction.toSendable());
+        this.displayOutcome("Transaction signed.", signedTransaction.toSendable());
     }
 
     async signTransactions() {
@@ -101,9 +101,9 @@ export class HW {
         });
 
         const transactions = [firstTransaction, secondTransaction];
-        await this.provider.signTransactions(transactions);
+        const signedTransactions = await this.provider.signTransactions(transactions);
 
-        this.displayOutcome("Transactions signed.", transactions.map((transaction) => transaction.toSendable()));
+        this.displayOutcome("Transactions signed.", signedTransactions.map((transaction) => transaction.toSendable()));
     }
 
     async signGuardedTransaction() {
@@ -133,9 +133,9 @@ export class HW {
             })
         });
 
-        await this.provider.signTransaction(transaction);
+        const signedTransaction = await this.provider.signTransaction(transaction);
 
-        this.displayOutcome("Transaction signed.", transaction.toSendable());
+        this.displayOutcome("Transaction signed.", signedTransaction.toSendable());
     }
 
     async signMessage() {
@@ -145,9 +145,9 @@ export class HW {
             message: Buffer.from("hello")
         });
 
-        await this.provider.signMessage(message);
+        const signedMessage = await this.provider.signMessage(message);
 
-        this.displayOutcome("Message signed.", message);
+        this.displayOutcome("Message signed.", signedMessage);
     }
 
     displayOutcome(message, outcome) {

diff --git a/signing-providers/src/web-wallet.js b/signing-providers/src/web-wallet.js
@@ -45,27 +45,35 @@ export class WebWallet {
 
     async signTransaction() {
         const sender = getUrlParams().address;
+        if (!sender) {
+            alert("Try to login first.");
+            return;
+        }
+
         const transaction = new Transaction({
             nonce: 42,
-            value: "1",
+            value: "1000000000000000000",
             sender: new Address(sender),
             receiver: new Address("erd1uv40ahysflse896x4ktnh6ecx43u7cmy9wnxnvcyp7deg299a4sq6vaywa"),
             gasPrice: 1000000000,
             gasLimit: 50000,
             data: new TransactionPayload(),
-            chainID: "T",
-            version: 1
+            chainID: "T"
         });
 
         await this.provider.signTransaction(transaction);
     }
 
     async signTransactions() {
         const sender = getUrlParams().address;
+        if (!sender) {
+            alert("Try to login first.");
+            return;
+        }
 
         const firstTransaction = new Transaction({
             nonce: 42,
-            value: "1",
+            value: "1000000000000000000",
             gasLimit: 70000,
             sender: new Address(sender),
             receiver: new Address("erd1uv40ahysflse896x4ktnh6ecx43u7cmy9wnxnvcyp7deg299a4sq6vaywa"),
@@ -75,7 +83,7 @@ export class WebWallet {
 
         const secondTransaction = new Transaction({
             nonce: 43,
-            value: "1",
+            value: "3000000000000000000",
             gasLimit: 70000,
             sender: new Address(sender),
             receiver: new Address("erd1uv40ahysflse896x4ktnh6ecx43u7cmy9wnxnvcyp7deg299a4sq6vaywa"),