FIX(client): Use SPSC queue for global shortcuts on Windows #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
changed the title
Krzmbrzl
reviewed
Oct 29, 2022
davidebeatrici
commented
Oct 31, 2022
A bounded single-producer single-consumer wait-free and lock-free queue written in C++11. It is going to be used for the Windows implementation of global shortcuts.
davidebeatrici
force-pushed
the
globalshortcutwin-spsc-queue
branch
from
49154cb to
abe1fbd
Compare
Krzmbrzl
approved these changes
Dec 30, 2022
We've been receiving quite a few reports about the program seemingly freezing, such as https://forums.mumble.info/topic/14467-14-conflict-with-flight-control-rudder-pedals. Turns out there are HID devices, namely advanced controllers, that constantly send packets. The reason behind the behavior is probably to prevent games from losing track of the physical state. Qt's event dispatcher blows up and consumes all resources, leading to: QEventDispatcherWin32::registerTimer: Failed to create a timer (The current process has used all of its system allowance of handles for Window Manager objects.) As a result, the UI completely freezes due to events not being processed anymore. This commit fixes the issue by using an SPSC (Single Producer Single Consumer) queue. The event loop and 20 ms timer are removed. The latter was strictly used for XInput and G-keys polling. Both backends still work, potentially better than before: no more polling! Whenever a HID message is received, the relevant code is executed.
davidebeatrici
force-pushed
the
globalshortcutwin-spsc-queue
branch
from
abe1fbd to
3710484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been receiving quite a few reports about the program seemingly freezing, such as
https://forums.mumble.info/topic/14467-14-conflict-with-flight-control-rudder-pedals.
Turns out there are HID devices, namely advanced controllers, that constantly send packets.
The reason behind the behavior is probably to prevent games from losing track of the physical state.
Qt's event dispatcher blows up and consumes all resources, leading to:
As a result, the UI completely freezes due to events not being processed anymore.
This commit fixes the issue by using an SPSC (Single Producer Single Consumer) queue.
The event loop and 20 ms timer are removed. The latter was strictly used for XInput and G-keys polling.
Both backends still work, potentially better than before: no more polling!
Whenever a HID message is received, the relevant code is executed.