Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Merge PR #6170: REFAC(plugins): Unified Mumble plugin headers" to 1.5.x #6225

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented Oct 6, 2023

Backport

This will backport the following commits from master to 1.5.x:

Questions ?

Please refer to the Backport tool documentation

Having different include files that are needed (and which are
inter-dependent) to create your own plugin, makes things harder than it
needs to be.

Therefore, all plugin header files (those for the "new" (1.4) plugin
framework anyway) have been combined into one header file. Thus,
developers now only have to download a single file and include that
instead of having to figure out what files to download and what to
include where.

Taking the chance, the version number has been removed from the header
file's name. This allows one to track changes made to the API via git
(which is not quite as easy if you create a new file every time you make
a change).

(cherry picked from commit 2b35c0c)
@Krzmbrzl Krzmbrzl self-assigned this Oct 6, 2023
@Krzmbrzl Krzmbrzl merged commit 586264a into 1.5.x Oct 7, 2023
20 checks passed
@Krzmbrzl Krzmbrzl deleted the backport/1.5.x/pr-6170 branch October 7, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant