FIX(client): Don't assume SSL error == SSL version mismatch #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experience shows that SSL handshake errors can have various different reasons and thus always reporting that Mumble has encountered an SSL version mismatch is no good. This rephrases the error message to reflect this more general nature of the possible error origin and also provides advice for the most commonly observed ones.
Krzmbrzl
force-pushed
the
improve-ssl-error-message
branch
from
71e04fa
to
1329381
Compare
Hartmnt
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experience shows that SSL handshake errors can have various different
reasons and thus always reporting that Mumble has encountered an SSL
version mismatch is no good.
This rephrases the error message to reflect this more general nature of
the possible error origin and also provides advice for the most commonly
observed ones.
Checks