[Module/idlemove] Store user's original channel (fixes #13) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dirty but good. |
Kissaki
force-pushed
the
master
branch
3 times, most recently
from
7d19720
to
1f36911
Compare
Kissaki
requested changes
Mar 15, 2024
There was a problem hiding this comment.
review notes:
affectedusers type dict, key: server id, value: set "index" of user session ids
on update the session id is added and removed to index respectively
I think it would make more sense to store the origchan with the session id, in the same structure, instead of with a different type of key and separate to it.
While this works, I don't think it's very maintainable. The key mismatch is confusing, and what we want to remember together is not together.
The PR source branch repository has been archived, so I can't push a rebase conflict resolution.
Python and this long idlemove type is a hassle and barrier to me.
I would
- Change
affecteduserstype fromsettodict, with key user session id and value orig channel id
|
Migrated to PR #14 |
Kissaki
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this all too much and it might be too dirty hackish, but it does seem to work.