Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS version usage information #217

Closed
flbulgarelli opened this issue Jan 8, 2019 · 4 comments · Fixed by #218
Closed

Update JS version usage information #217

flbulgarelli opened this issue Jan 8, 2019 · 4 comments · Fixed by #218
Assignees

Comments

@flbulgarelli
Copy link
Member

We must update:

  • npm install samples
  • node usage samples as library code
  • node usage samples as standalone program
  • deployment instructions
  • ghcjslib README
@flbulgarelli
Copy link
Member Author

See #207 (comment)

@flbulgarelli
Copy link
Member Author

PS: I am not being able to run mulang-cli

@julian-berbel
Copy link
Member

PS: I am not being able to run mulang-cli

aaaagggghhhhhhh. Apparently the package bin doesn't assume the given files are js files to be run with node, but rather it should take files that are directly executable by the os (we just need to add #!/usr/bin/env node at the beginning of the file) ((also, the require path is wrong, when deployed both mulang-cli and mulang are in the same folder, so it should not have build/ in it))

@julian-berbel
Copy link
Member

julian-berbel commented Jan 9, 2019

Maybe it would be better to keep the same directory structure between the published package and development, since adding the aforementioned changes to the index.js file would then fix the published version, but break development

@flbulgarelli flbulgarelli self-assigned this Jan 9, 2019
@ghost ghost added the in progress label Jan 9, 2019
@flbulgarelli flbulgarelli mentioned this issue Jan 9, 2019
7 tasks
julian-berbel added a commit that referenced this issue Jan 10, 2019
@ghost ghost removed the in progress label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants