Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature improved ruby interface #247

Merged
merged 13 commits into from
Sep 22, 2019
Merged

Conversation

flbulgarelli
Copy link
Member

@flbulgarelli flbulgarelli commented Sep 11, 2019

This PR adds a some methods for easier expectations evaluation, and incorporates mumukit-inspection concepts to this gem.

Pending:

  • Add support for matchers parsing
  • Add support for matchers translation

Copy link
Member

@julian-berbel julian-berbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Are we deprecating mumukit-inspection with this?

gem/lib/mulang/inspection.rb Outdated Show resolved Hide resolved
@flbulgarelli
Copy link
Member Author

Looks great! Are we deprecating mumukit-inspection with this?

Exactly, that is my intention. That way we don't have to keep two repositories in sync when we add a new inspection or we support a new inspection format.

@flbulgarelli flbulgarelli merged commit 112cab2 into master Sep 22, 2019
@flbulgarelli flbulgarelli deleted the feature-improved-ruby-interface branch September 22, 2019 16:25
@flbulgarelli
Copy link
Member Author

@julian-berbel I have merged this PR but I still would like to hear your comments about latest commits

Copy link
Member

@julian-berbel julian-berbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants