Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature user delete #1406

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Feature user delete #1406

merged 4 commits into from
Jun 1, 2020

Conversation

flbulgarelli
Copy link
Member

@flbulgarelli flbulgarelli commented May 28, 2020

🎯 Goal

This PR adds UI support for disabled users. It checks user is enabled on every request, except in sessions controller - to permit logout.

🔙 Backward compatibility

This PR does not introduce any backward incompatibilities but a new feature. It should go to a minor release.

👀 Relations

Copy link
Contributor

@luchotc luchotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I haven't tested this manually but looking at the flow I think this is what we want 😄

@felipecalvo
Copy link
Contributor

felipecalvo commented May 28, 2020

Gemfile might conflict as I lost 5820c5c at some point when rebasing #1401, so I merged pointing to a domain branch instead of master. Just overwrite it.

@flbulgarelli flbulgarelli marked this pull request as ready for review May 29, 2020 17:30
@flbulgarelli flbulgarelli requested a review from luchotc May 29, 2020 17:47
@flbulgarelli flbulgarelli merged commit 0f74cf8 into master Jun 1, 2020
@flbulgarelli flbulgarelli deleted the feature-user-delete branch June 1, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants