Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore immersive fix #1609

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Chore immersive fix #1609

wants to merge 4 commits into from

Conversation

luchotc
Copy link
Contributor

@luchotc luchotc commented Apr 22, 2021

🎯 Goal

Fix immersive redirections

📝 Details

You'll see that I'm not adding or changing any tests. This is because we are currently using Subdomain as the default organization_mapping and this PRs fixes the Path scenarios that were failing but they are untested.

⚠️ Dependencies

mumuki/mumuki-domain#207
mumuki/mumukit-platform#46

🔙 Backwards compatibility

100%

🔜 Future work

Use Path as organization_mapping for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant