Issue#952 feature progressive tips #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
julian-berbel
force-pushed
the
issue#952-feature-progressive-tips
branch
from
27834dc
to
520efc5
Compare
|
Code looks good. I'd like to see an screenshot, too. |
|
Please implement the bibliotheca side of this issue and then I will merge it. |
|
per @flbulgarelli's request: |
|
@fedescarpa please review |
fedescarpa
reviewed
Apr 9, 2018
app/models/submission/submission.rb
Outdated
| assignment.update! results | ||
| assignment.failed_submissions_count += 1 unless results[:status] == :passed | ||
| assignment.update results | ||
| assignment.save! |
There was a problem hiding this comment.
@flbulgarelli, update + save! is not the same that update!?
There was a problem hiding this comment.
But only in the scenario you did not assign unsaved attributes before update.
|
@fedescarpa please propose UI improvements. |
fedescarpa
reviewed
Apr 9, 2018
There was a problem hiding this comment.
Please @flbulgarelli view my comment. The rest of the PR LGTM
|
About the UI I don't have greater ideas, I think it's fine just like this |
flbulgarelli
force-pushed
the
issue#952-feature-progressive-tips
branch
from
520efc5
to
e2693da
Compare
flbulgarelli
force-pushed
the
issue#952-feature-progressive-tips
branch
from
e2693da
to
c10292b
Compare
This was referenced May 25, 2018
Closed
|
Closing. This PR is included in #1072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
The real location for the tips still needs to be decided.
Fixes #952.