Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(abi): move privacy and name from FunctionSignature to FunctionInfo #146

Closed
3 tasks done
baszalmstra opened this issue May 1, 2020 · 2 comments
Closed
3 tasks done

refactor(abi): move privacy and name from FunctionSignature to FunctionInfo #146

baszalmstra opened this issue May 1, 2020 · 2 comments
Assignees
@baszalmstra
Labels
good first issue Good for newcomers

Comments

@baszalmstra
Copy link
Collaborator

baszalmstra commented May 1, 2020 •
edited by Wodann
Loading

Current the FunctionSignature contains this information. We need to move that to FunctionInfo.

Good first issue process:

If this is your first PR, welcome 🎉 😄
@baszalmstra baszalmstra added the good first issue Good for newcomers label May 1, 2020
@Wodann Wodann changed the title Refactor ABI so that FunctionInfo contains privacy and name refactor(abi): move privacy and name from signature to FunctionInfo May 2, 2020
@Wodann Wodann changed the title refactor(abi): move privacy and name from signature to FunctionInfo refactor(abi): move privacy and name from FnSignature to FunctionInfo May 2, 2020
@Wodann Wodann changed the title refactor(abi): move privacy and name from FnSignature to FunctionInfo refactor(abi): move privacy and name from FunctionSignature to FunctionInfo May 2, 2020
@attila-lin
Copy link

I'd like to take it.

@baszalmstra
Copy link
Collaborator Author

Ah thats super good to hear! Welcome :)

However, I forgot to update this issue, we've already done this in #166 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baszalmstra baszalmstra

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@attila-lin @baszalmstra