Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Rust version #247

Closed
3 tasks done
baszalmstra opened this issue Jul 25, 2020 · 2 comments · Fixed by #269
Closed
3 tasks done

Pin Rust version #247

baszalmstra opened this issue Jul 25, 2020 · 2 comments · Fixed by #269
Assignees
Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: build Changes that affect the build system or external dependencies
Milestone

Comments

@baszalmstra
Copy link
Collaborator

baszalmstra commented Jul 25, 2020

Everytime Rust releases a new version our builds break. This happens because new lints are added for instance. We want to keep up to date with the latest Rust version but its anoying that if someone submits a PR CI might fail because a new Rust version was just released.

I propose we do something similar to vector, they store a file that stores which version of Rust CI should use. Its trivial to bump Mun to a new Rust version by creating a new PR that modifies the contents of that file together with fixing any issues that may be caused by the version bump.

To implement this we just need to modify our CI workflow to read the version to use from a file.

Good first issue process:

If this is your first PR, welcome 🎉 😄

@baszalmstra baszalmstra added good first issue Good for newcomers type: perf Changes that improve performance pri: low An issue with no impact to quality, performance, or functionality exp: low Achievable with little prior knowledge and guidance labels Jul 25, 2020
@sinato
Copy link
Contributor

sinato commented Sep 18, 2020

Hi, I would like to try doing this.

@Wodann
Copy link
Collaborator

Wodann commented Sep 18, 2020

Excellent! As always, please let @baszalmstra or me know if you have any questions.

@Wodann Wodann added this to the Mun v0.3.0 milestone Sep 20, 2020
@Wodann Wodann added type: build Changes that affect the build system or external dependencies and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants