Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: return Rc<RefCell<Runtime>> from builder #153

Merged
merged 1 commit into from
May 1, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented May 1, 2020

No description provided.

@Wodann Wodann requested a review from baszalmstra May 1, 2020 09:21
@Wodann Wodann self-assigned this May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #153 into master will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files         160      160           
  Lines       11022    11028    +6     
=======================================
+ Hits         9067     9072    +5     
- Misses       1955     1956    +1     
Impacted Files Coverage Δ
crates/mun/src/main.rs 0.00% <0.00%> (ø)
crates/mun_runtime/src/lib.rs 71.87% <71.42%> (-0.17%) ⬇️
crates/mun_runtime/tests/util.rs 90.90% <100.00%> (ø)
crates/mun_runtime_capi/src/lib.rs 96.96% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c9169...4d591ee. Read the comment docs.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ergonomic change

@Wodann Wodann merged commit 99476eb into mun-lang:master May 1, 2020
@Wodann Wodann changed the title improvement: return Rc<RefCell<Runtime>> from builder improvement: return Rc<RefCell<Runtime>> from builder May 2, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
@Wodann Wodann deleted the improvement/runtime branch May 14, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants