Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: removed float, int, uint #157

Merged

Conversation

baszalmstra
Copy link
Collaborator

This PR removes the int, uint and float types.

These types are superseded by the concrete types i32, u32 and f64 types. Initially, we felt that people don't care about bitness but we came to the conclusion that we needed to implement sized types as well. Once those were in place we found that the float, int, uint types were verbose and no longer required.

There is a seperate PR to remove them from the book.

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #157 into master will decrease coverage by 0.05%.
The diff coverage is 81.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   82.74%   82.69%   -0.06%     
==========================================
  Files         162      162              
  Lines       11137    11115      -22     
==========================================
- Hits         9215     9191      -24     
- Misses       1922     1924       +2     
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/body.rs 84.80% <ø> (ø)
crates/mun_codegen/src/ir/ty.rs 100.00% <ø> (ø)
crates/mun_codegen/src/test.rs 98.11% <ø> (ø)
crates/mun_compiler/src/diagnostics.rs 93.26% <ø> (ø)
crates/mun_hir/src/builtin_type.rs 51.06% <ø> (+0.12%) ⬆️
crates/mun_hir/src/expr.rs 88.43% <ø> (-0.27%) ⬇️
crates/mun_hir/src/tests.rs 84.61% <ø> (ø)
crates/mun_hir/src/ty/primitives.rs 63.63% <ø> (+0.25%) ⬆️
crates/mun_hir/src/ty/resolve.rs 62.50% <ø> (-15.28%) ⬇️
crates/mun_hir/src/ty/tests.rs 96.29% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e3b79...124cf19. Read the comment docs.

@baszalmstra baszalmstra self-assigned this May 2, 2020
@baszalmstra baszalmstra requested a review from Wodann May 2, 2020 11:09
crates/mun_runtime/tests/util.rs Outdated Show resolved Hide resolved
crates/mun_runtime/tests/util.rs Outdated Show resolved Hide resolved
crates/mun_syntax/src/ast/expr_extensions.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra force-pushed the feat/removed_int_float_uint branch from 8230d9f to 124cf19 Compare May 2, 2020 12:19
@baszalmstra baszalmstra merged commit 70322b7 into mun-lang:master May 2, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants