Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: enables adding extern functions through c api #169

Merged
merged 2 commits into from
May 13, 2020

Conversation

baszalmstra
Copy link
Collaborator

Enables adding extern functions to the runtime through the C api

Uses: mun-lang/runtime-ffi#7

@baszalmstra baszalmstra requested a review from Wodann May 8, 2020 14:03
@baszalmstra baszalmstra self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #169 into master will increase coverage by 0.10%.
The diff coverage is 72.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   82.76%   82.87%   +0.10%     
==========================================
  Files         163      163              
  Lines       11240    11267      +27     
==========================================
+ Hits         9303     9337      +34     
+ Misses       1937     1930       -7     
Impacted Files Coverage Δ
crates/mun_runtime_capi/src/lib.rs 85.52% <43.75%> (-11.25%) ⬇️
crates/mun_abi/src/autogen_impl.rs 95.50% <75.00%> (+2.49%) ⬆️
crates/mun_runtime/tests/marshalling.rs 98.97% <75.00%> (-0.51%) ⬇️
crates/mun_runtime/src/assembly.rs 71.42% <85.71%> (+8.66%) ⬆️
crates/mun_runtime_capi/src/tests.rs 99.48% <100.00%> (+0.01%) ⬆️
crates/mun_runtime/src/macros.rs 69.64% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797f501...3e14715. Read the comment docs.

crates/mun_runtime_capi/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BEWARE] Before merging, do have a look at the other PR. I had some comments there.

@baszalmstra baszalmstra force-pushed the feature/c-extern-functions branch from 7e1196d to 7207503 Compare May 13, 2020 20:33
baszalmstra and others added 2 commits May 13, 2020 22:48
@baszalmstra baszalmstra force-pushed the feature/c-extern-functions branch from 7207503 to 3e14715 Compare May 13, 2020 20:48
@Wodann Wodann merged commit 513194b into mun-lang:master May 13, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants