Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: pin rust version to 1.46.0 #269

Merged
merged 4 commits into from
Sep 20, 2020
Merged

build: pin rust version to 1.46.0 #269

merged 4 commits into from
Sep 20, 2020

Conversation

sinato
Copy link
Contributor

@sinato sinato commented Sep 18, 2020 •
edited
Loading

This PR pins the version of the rust toolchain to be used in the build and CI of this project ( closes #247 ) .

@codecov
Copy link

codecov bot commented Sep 18, 2020 •
edited
Loading

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         214      214           
  Lines       12808    12808           
=======================================
  Hits        10125    10125           
  Misses       2683     2683

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6887b73...a1fedce. Read the comment docs.

@sinato sinato changed the title check ci build: pin rust version Sep 18, 2020
@sinato sinato marked this pull request as ready for review September 19, 2020 15:11
@baszalmstra
Copy link
Collaborator

With these changes, I think you can also remove the nightly and beta CI stages. They dont make sense to me if you pin the Rust version anyway. WDYT? what does vector do?

@Wodann Wodann requested a review from baszalmstra September 19, 2020 20:56
@sinato
Copy link
Contributor Author

sinato commented Sep 20, 2020

With these changes, I think you can also remove the nightly and beta CI stages. They dont make sense to me if you pin the Rust version anyway. WDYT? what does vector do?

As far as I understand, vector only use the pinned version and stable. I also think beta and nightly are no longer needed.
Fixed: a1fedce

@Wodann
Copy link
Collaborator

Wodann commented Sep 20, 2020

Just checking, but did you want to squash some of the commits or can I merge it as is? Either is fine by me 🙂

@sinato
Copy link
Contributor Author

sinato commented Sep 20, 2020

Thank you for the review! Can you merge them as is? I think each commit meaningful enough.

@Wodann Wodann merged commit c84daf7 into mun-lang:master Sep 20, 2020
@Wodann Wodann changed the title build: pin rust version build: pin rust version to 1.46.0 Sep 20, 2020
@Wodann Wodann added the type: perf Changes that improve performance label Sep 20, 2020
@Wodann Wodann added this to the Mun v0.3.0 milestone Sep 20, 2020
@sinato sinato deleted the check_ci branch September 20, 2020 15:20
@Wodann Wodann added type: build Changes that affect the build system or external dependencies and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@sinato sinato

Labels
type: build Changes that affect the build system or external dependencies
Projects
None yet
Milestone
Mun v0.3.0
Development

Successfully merging this pull request may close these issues.

Pin Rust version
3 participants
@sinato @baszalmstra @Wodann