-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: adds modules and visibility #283
Conversation
6c5d31b
to
8433895
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 79.34% 79.73% +0.39%
==========================================
Files 220 228 +8
Lines 13069 13500 +431
==========================================
+ Hits 10369 10764 +395
- Misses 2700 2736 +36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see this work nearing completion. Mun v0.3 is shaping up nicely!
This is only a partial review, but I wanted to make sure that part of my comments were already actionable. I'll continue the review later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next batch of reviewed files 😅
4347dd2
to
702e615
Compare
I think I solved all issues, also rebased everything on current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last batch of comments. Hopefully we can merge this soon 🌲
b1e14eb
to
95f3c65
Compare
95f3c65
to
6747bbc
Compare
6747bbc
to
56530c0
Compare
474f0bb
to
9da3be5
Compare
This (still way too large, Im sorry 😓 ) PR adds use of
pub
keywords and resolved visibility. It also introduces the concept of modules which are ordered in a hierarchical manner based on their location on disk. This is required to be able to specify visibility scopes. This PR also (again Im sorry for the size 😓 ) introduces the concept of definitions from all over the package in the form of PackageDefs. This can later be used to more easily implementuse
as well.All of this required quite the overhaul, especially because we have modules now instead of files.
Closes #248
This PR is still in Draft because I want to:
add diagnostics for missing module files (We decided that that is actually not an error.foo/
exists but nomod.rs
orfoo.rs
).