Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make type-specific data (such as StructInfo) part of TypeInfo #287

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #287 (26c8883) into master (1663f99) will decrease coverage by 0.02%.
The diff coverage is 96.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   80.89%   80.86%   -0.03%     
==========================================
  Files         244      245       +1     
  Lines       14952    14937      -15     
==========================================
- Hits        12095    12079      -16     
- Misses       2857     2858       +1     
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/types.rs 33.33% <ø> (-4.17%) ⬇️
crates/mun_codegen/src/type_info.rs 67.16% <66.66%> (+1.83%) ⬆️
crates/mun_codegen/tests/abi.rs 95.77% <75.00%> (-1.33%) ⬇️
crates/mun_abi/src/module_info.rs 98.21% <88.88%> (-1.79%) ⬇️
crates/mun_abi/src/dispatch_table.rs 93.67% <100.00%> (ø)
crates/mun_abi/src/function_info.rs 85.00% <100.00%> (ø)
crates/mun_abi/src/struct_info.rs 88.13% <100.00%> (ø)
crates/mun_abi/src/test_utils.rs 100.00% <100.00%> (ø)
crates/mun_abi/src/type_info.rs 82.53% <100.00%> (+1.14%) ⬆️
crates/mun_codegen/src/ir/ty.rs 83.33% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1663f99...26c8883. Read the comment docs.

@Wodann Wodann force-pushed the feat/type-info-data branch 2 times, most recently from b1f6c5a to e413750 Compare October 25, 2020 20:03
@Wodann
Copy link
Collaborator Author

Wodann commented Nov 1, 2020

Waiting for a cbindgen bug (mozilla/cbindgen#615) to be resolved, before I can merge.

@Wodann Wodann force-pushed the feat/type-info-data branch from e413750 to 92f10e6 Compare March 9, 2021 04:53
@Wodann Wodann force-pushed the feat/type-info-data branch from 92f10e6 to 7eab9b4 Compare March 9, 2021 05:11
@Wodann
Copy link
Collaborator Author

Wodann commented Mar 9, 2021

Ready to be merged, once you're happy @baszalmstra

@Wodann Wodann force-pushed the feat/type-info-data branch from 7eab9b4 to 26c8883 Compare April 1, 2021 00:51
@Wodann Wodann merged commit 034a2b4 into mun-lang:master Apr 1, 2021
@Wodann Wodann deleted the feat/type-info-data branch April 1, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Mun ABI to safely support StructInfo in TypeInfo
2 participants