feat: adds update operators and diagnostics #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
update_operators
branch
from
eefa40c to
e390a89
Compare
Wodann
reviewed
Oct 31, 2019
baszalmstra
force-pushed
the
update_operators
branch
from
e390a89 to
eefa40c
Compare
baszalmstra
force-pushed
the
update_operators
branch
from
7a765c9 to
379953d
Compare
Wodann
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
+=,-=,*=,/=operators.A lot of files seem to have changed but this is mostly due to how IR is generated for functions parameters. Now that all locals including parameters are mutable (mutability is for another PR) we need to be able to get a pointer to the storage of a parameter. This is not possible without allocating the locals on the stack first. This already happens for locally introduced variables but not for function parameters. For parameters an
allocais first performed, then the function parameter value is stored on the stack. LLVM optimizes this out again so there is no overhead. However, the tests differ because now the stack based parameter has the name of the parameter instead of the function parameter. This results in slightly differently generated IR naming but the operations are still the same.