refactor: use github actions and grcov #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces azure pipelines with github actions, tarpaulin with (cross-platform) grcov, and codecov.io with coveralls.io. Github Actions turned out to be a much better fit for this project. It integrates much better with our already existing workflow, seems more feature complete and is easier to work with. Tarpaulin kept crashing on Azure Pipelines and after trying also with Github Actions, its still under active development so thats not very strange. However, I prefer to have inaccurate code coverage than no coverage at all. Therefor I replaced Tarpaulin with grcov. grcov does report some lines missed that are actually ok but again, its better than nothing. Also, grcov works on all our target platforms so we get better cross platform coverage in return. I replaced codecov.io as our coverage service with coveralls.io. Although I like the interface of codecov better there is no support for uploading reports on macOS and windows. See codecov/codecov-action#13 for more information.
Wodann
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces azure pipelines with github actions, tarpaulin with
(cross-platform) grcov, and codecov.io with coveralls.io.
Github Actions turned out to be a much better fit for this project. It
integrates much better with our already existing workflow, seems more
feature complete and is easier to work with.
Tarpaulin kept crashing on Azure Pipelines and after trying also with
Github Actions, its still under active development so thats not very
strange. However, I prefer to have inaccurate code coverage than no
coverage at all. Therefor I replaced Tarpaulin with grcov. grcov does
report some lines missed that are actually ok but again, its better than
nothing. Also, grcov works on all our target platforms so we get better
cross platform coverage in return.
I replaced codecov.io as our coverage service with coveralls.io.
Although I like the interface of codecov better there is no support
for uploading reports on macOS and windows. See
codecov/codecov-action#13 for more
information.
For an example of a pipeline see the result of this branch.