Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add logo #355

Merged
merged 4 commits into from
Dec 16, 2021
Merged

docs(readme): add logo #355

merged 4 commits into from
Dec 16, 2021

Conversation

jonatcln
Copy link
Contributor

Adds the potential new logo of Mun to the README. This also makes it easier to discuss #198 (i.e. any adjustment that need to be made).

Points that require further thought:

  • Is the logo/shape OK?
  • What color should the logo be? What is Mun's branding color?
  • Should there be a logotype variant of the logo (one that includes the name Mun)?
  • Where should the reference logo be stored?

@Wodann
Copy link
Collaborator

Wodann commented Nov 29, 2021

Thank you so much for putting this together.

Those are great questions! @baszalmstra and I are having a call to work on Mun on December 11th. If you don't mind, we'll discuss the questions then and follow up afterwards 🙂

@baszalmstra
Copy link
Collaborator

I also added this logo to the website, here is the PR: mun-lang/website#84

@Wodann
Copy link
Collaborator

Wodann commented Dec 11, 2021

Is the logo/shape OK?

Yes, it looks perfect!

What color should the logo be? What is Mun's branding color?

The current colour scheme works! Would you also be able to make the inverse (i.e. replace black with white, and vice versa) to support dark mode. Github's Markdown actually supports specifying images for dark/light mode.

Should there be a logotype variant of the logo (one that includes the name Mun)?

If you would be able to make versions with the name "Mun" offset to the right too, we would really appreciate that! This is the font that we use: https://public-sans.digital.gov/

For reference, you can have a look at this PR, but feel free to design the layout to your liking 🙂

Where should the reference logo be stored?

The assets folder that you've created works for us :)

@jonatcln
Copy link
Contributor Author

Github's Markdown actually supports specifying images for dark/light mode.

Cool! Didn't know that. I added a white version for both the logo and the logotype. GitHub doesn't seem to allow these light/dark-mode-only variants in html img tags, so I couldn't specify the image height in the README but instead embedded it in the svg itself. I thought it would therefore be best to separate the actual logo(type)s (without specific height) from the ones in the README. In order to distinguish them I organized the logo(type)s in two subfolders: assets/logo and assets/readme.

Let me know if you have any other suggestions 🙂

@jonatcln
Copy link
Contributor Author

jonatcln commented Dec 12, 2021

I also quickly made this 'blueprint' of the design:

logotype-blueprint

I'm not sure what to do with it, but it might be handy for future reference.

Also, fun fact: most of the dimensions (the circle-based shapes in particular) originate from this variant of the Fibonacci sequence: 48, 48, 72, 120, 192, 312, 504, ... (because the ratio of two consecutive Fibonacci numbers approximates the golden ratio)

@baszalmstra
Copy link
Collaborator

It looks incredible! Thank you so much 😊

@baszalmstra baszalmstra requested a review from Wodann December 13, 2021 07:49
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #355 (9c12a62) into main (020b96e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         263      263           
  Lines       15217    15217           
=======================================
  Hits        12579    12579           
  Misses       2638     2638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020b96e...9c12a62. Read the comment docs.

@baszalmstra baszalmstra merged commit b9ead75 into mun-lang:main Dec 16, 2021
@baszalmstra
Copy link
Collaborator

Thanks so much! :)

@jonatcln jonatcln deleted the logo branch February 10, 2022 08:35
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants