-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add logo #355
Conversation
Thank you so much for putting this together. Those are great questions! @baszalmstra and I are having a call to work on Mun on December 11th. If you don't mind, we'll discuss the questions then and follow up afterwards 🙂 |
I also added this logo to the website, here is the PR: mun-lang/website#84 |
Yes, it looks perfect!
The current colour scheme works! Would you also be able to make the inverse (i.e. replace black with white, and vice versa) to support dark mode. Github's Markdown actually supports specifying images for dark/light mode.
If you would be able to make versions with the name "Mun" offset to the right too, we would really appreciate that! This is the font that we use: https://public-sans.digital.gov/ For reference, you can have a look at this PR, but feel free to design the layout to your liking 🙂
The |
Cool! Didn't know that. I added a white version for both the logo and the logotype. GitHub doesn't seem to allow these light/dark-mode-only variants in html img tags, so I couldn't specify the image height in the README but instead embedded it in the svg itself. I thought it would therefore be best to separate the actual logo(type)s (without specific height) from the ones in the README. In order to distinguish them I organized the logo(type)s in two subfolders: Let me know if you have any other suggestions 🙂 |
I also quickly made this 'blueprint' of the design: I'm not sure what to do with it, but it might be handy for future reference. Also, fun fact: most of the dimensions (the circle-based shapes in particular) originate from this variant of the Fibonacci sequence: 48, 48, 72, 120, 192, 312, 504, ... (because the ratio of two consecutive Fibonacci numbers approximates the golden ratio) |
It looks incredible! Thank you so much 😊 |
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 263 263
Lines 15217 15217
=======================================
Hits 12579 12579
Misses 2638 2638 Continue to review full report at Codecov.
|
Thanks so much! :) |
Adds the potential new logo of Mun to the README. This also makes it easier to discuss #198 (i.e. any adjustment that need to be made).
Points that require further thought: