Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add M1 support #444

Merged
merged 9 commits into from
Oct 31, 2022
Merged

feat: add M1 support #444

merged 9 commits into from
Oct 31, 2022

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Aug 27, 2022

No description provided.

@Wodann Wodann added the type: feat New feature or request label Aug 27, 2022
@Wodann Wodann added this to the Mun v0.4.0 milestone Aug 27, 2022
@Wodann Wodann requested a review from baszalmstra August 27, 2022 21:13
@Wodann Wodann self-assigned this Aug 27, 2022
@Wodann Wodann changed the title feat: add m1 support feat: add M1 support Aug 27, 2022
Wodann and others added 2 commits August 27, 2022 16:37
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #444 (4ca4488) into main (3f7b316) will decrease coverage by 0.04%.
The diff coverage is 53.84%.

❗ Current head 4ca4488 differs from pull request most recent head f624888. Consider uploading reports for the commit f624888 to get more accurate results

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   79.35%   79.30%   -0.05%     
==========================================
  Files         255      256       +1     
  Lines       13464    13483      +19     
==========================================
+ Hits        10684    10693       +9     
- Misses       2780     2790      +10     
Impacted Files Coverage Δ
crates/mun_target/src/spec.rs 86.36% <ø> (ø)
crates/mun_target/src/spec/aarch64_apple_darwin.rs 0.00% <0.00%> (ø)
crates/mun_codegen/src/assembly.rs 85.10% <40.00%> (-5.37%) ⬇️
crates/mun_runtime/src/lib.rs 77.29% <84.61%> (+0.20%) ⬆️
crates/mun_target/src/spec/apple_base.rs 56.66% <100.00%> (+1.49%) ⬆️
crates/mun_hir/src/ty/infer/type_variable.rs 81.25% <0.00%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@baszalmstra
Copy link
Collaborator

Im looking into the disk space issue.

@baszalmstra
Copy link
Collaborator

Our build is using more than 14gb. Do you think we can remove some dependencies? Or maybe we can not build the dependencies for the benchmarks? We are not running them anyway in CI and cargo check still checks them (I think).

@Wodann
Copy link
Collaborator Author

Wodann commented Sep 5, 2022

Our build is using more than 14gb. Do you think we can remove some dependencies? Or maybe we can not build the dependencies for the benchmarks? We are not running them anyway in CI and cargo check still checks them (I think).

I actually started looking through our dependencies with tools, in order to remove them. The tricky part is that our inkwell dependency prohibits us from using any of the normal tooling, as it cannot resolve its version naming.

@Wodann Wodann merged commit e07e077 into mun-lang:main Oct 31, 2022
@Wodann Wodann deleted the fix/m1 branch October 31, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants