-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: llvm from 13 to 14 #495
Conversation
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 87.17% 87.09% -0.08%
==========================================
Files 275 274 -1
Lines 31046 31082 +36
==========================================
+ Hits 27064 27071 +7
- Misses 3982 4011 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure to also add a changelog :)
Thanks I modified the changelog. To get this to work on macOS I had to refactor the apple targets again a little bit. I think they are actually simpler now. It works on my old x86_64 MacBook but I don't have access to an M1. Would you be able to run the tests locally @Wodann ? |
Yup, I'll checkout your branch and run it 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my M1 and LGTM!
I released lld-rs for LLD 14 and updated the dependency in this branch. If CI succeeds we can merge. |
Bump LLVM from 13 to 14.